FED-3528 React 18 dual support #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added interop for new filterNode option for prettyDom + Fixed misc. tests — JS CHANGELOGS — - https://github.com/testing-library/dom-testing-library/releases/tag/v8.0.0 - https://github.com/testing-library/react-testing-library/releases/tag/v12.0.0
Derived from building master (3.0.2) with the following changes:
diff --git a/js_src/rollup.config.js b/js_src/rollup.config.js
index 38448f5..e8432dfc 100644
--- a/js_src/rollup.config.js
+++ b/js_src/rollup.config.js
@@ -68 +68 @@ export default (commandFlags) => {
- format: 'umd',
+ format: 'esm',
This reverts commit fd02c66.
# Conflicts: # pubspec.yaml
# Conflicts: # .github/workflows/dart_ci.yml
sydneyjodon-wk
requested review from
greglittlefield-wf,
kealjones-wk and
aaronlademann-wf
greglittlefield-wf
requested changes
May 13, 2025
greglittlefield-wf
previously approved these changes
May 20, 2025
greglittlefield-wf
approved these changes
May 20, 2025
There was a problem hiding this comment.
- Changes look good
- CI passes
- CI is running in both React 17 and 18, and tagged tests validate that both 17 and 18 are actually being tested against
- React 17 bundle
- Verified that rtl-17.esm.js exactly matches master's JS bundle, except for UMD->ESM import/export boilerplate
- Accessible name whitespace regression test passes/fails as expected
- JS bundle step fails when there are untracked changes
- All AC addressed
+10
aaronlademann-wf
approved these changes
May 20, 2025
btr-rmconsole-2
bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'll need to set up dual support for React 17 and 18 in react_testing_library (RTL).
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: